Skip to content

dh_set_key + dsa_set_key#249

Merged
sjaeckel merged 2 commits intorelease/1.18.0from
pr/dh-dsa-api
Jul 11, 2017
Merged

dh_set_key + dsa_set_key#249
sjaeckel merged 2 commits intorelease/1.18.0from
pr/dh-dsa-api

Conversation

@karel-m
Copy link
Copy Markdown
Member

@karel-m karel-m commented Jul 10, 2017

see #248

@karel-m karel-m added this to the v1.18.0 milestone Jul 10, 2017
[skip ci]
@sjaeckel
Copy link
Copy Markdown
Member

Now the API is at least consistent on the DH part where we have dh_export_key() and dh_set_key() with the same signature. DSA still misses that part, but I also don't know if that's really relevant.

@sjaeckel sjaeckel merged commit 70f8a57 into release/1.18.0 Jul 11, 2017
@karel-m
Copy link
Copy Markdown
Member Author

karel-m commented Jul 11, 2017

DSA still misses that part, but I also don't know if that's really relevant.

You mean missing dsa_export_key()? Well, it would be consistent, but I personally do not need it at the moment. The dsa_set_key() I use in my perl bindings when importing DSA keys in SSH format (first I extract the raw values which I pass later to dsa_set_key).

@sjaeckel sjaeckel deleted the pr/dh-dsa-api branch July 11, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants